Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fizz] Include componentStack at the root when aborting #31011

Merged
merged 1 commit into from
Sep 20, 2024
Merged

[Fizz] Include componentStack at the root when aborting #31011

merged 1 commit into from
Sep 20, 2024

Conversation

gnoff
Copy link
Collaborator

@gnoff gnoff commented Sep 20, 2024

When aborting we currently don't produce a componentStack when aborting the shell. This is likely just an oversight and this change updates this behavior to be consistent with what we do when there is a boundary

@gnoff
[Fizz] Include componentStack at the root when aborting
48bc371 
WHen aborting we currently don't produce a componentStack when aborting the shell. This is likely just an oversight and this change updates this behvaior to be consistent with what we do when there is a boundary
@vercel Vercel
Copy link

vercel bot commented Sep 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2024 4:43pm

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Sep 20, 2024
@react-sizebot
Copy link

Comparing: e495392...396127c

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.05% 1.82 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 508.22 kB 508.22 kB = 90.95 kB 90.95 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB +0.05% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 513.15 kB 513.15 kB = 91.67 kB 91.67 kB
facebook-www/ReactDOM-prod.classic.js = 602.57 kB 602.57 kB = 106.64 kB 106.64 kB
facebook-www/ReactDOM-prod.modern.js = 578.84 kB 578.84 kB = 102.76 kB 102.76 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 48bc371

@gnoff gnoff merged commit ae75d5a into facebook:main Sep 20, 2024
184 checks passed
@gnoff gnoff deleted the include-stack-at-root branch September 20, 2024 17:00
github-actions bot pushed a commit that referenced this pull request Sep 20, 2024
@gnoff
[Fizz] Include componentStack at the root when aborting (#31011)
fe28b5d 
When aborting we currently don't produce a componentStack when aborting
the shell. This is likely just an oversight and this change updates this
behavior to be consistent with what we do when there is a boundary

DiffTrain build for [ae75d5a](ae75d5a)
@vercel-release-bot vercel-release-bot mentioned this pull request Sep 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebmarkbage sebmarkbage sebmarkbage approved these changes

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gnoff @react-sizebot @sebmarkbage @facebook-github-bot