[rcr] Remove runtimeModule compiler option #31055
Open
+5
−135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This was referenced Sep 24, 2024
poteto
added a commit
that referenced
this pull request
Sep 24, 2024
Now that the compiler always injects `react-compiler-runtime`, this option is unnecessary. ghstack-source-id: f0c73da24cc1c9167aff1f9cdd14487a85518b08 Pull Request resolved: #31055
facebook-github-bot
added
CLA Signed
React Core Team
poteto
added a commit
that referenced
this pull request
Sep 24, 2024
Now that the compiler always injects `react-compiler-runtime`, this option is unnecessary. ghstack-source-id: f0c73da24cc1c9167aff1f9cdd14487a85518b08 Pull Request resolved: #31055
poteto
added a commit
that referenced
this pull request
Sep 24, 2024
Now that the compiler always injects `react-compiler-runtime`, this option is unnecessary. ghstack-source-id: b6990b26072c52d04e268c5d91ddb13bc5b12f88 Pull Request resolved: #31055
poteto
added a commit
that referenced
this pull request
Sep 26, 2024
Now that the compiler always injects `react-compiler-runtime`, this option is unnecessary. ghstack-source-id: 0c65d96237f3274cc2af23c7489a936d66d38967 Pull Request resolved: #31055
poteto
added a commit
that referenced
this pull request
Sep 26, 2024
Now that the compiler always injects `react-compiler-runtime`, this option is unnecessary. ghstack-source-id: 159d6c40d772a10d7e5ef2674d6105db20f70732 Pull Request resolved: #31055
poteto
added a commit
that referenced
this pull request
Sep 26, 2024
Now that the compiler always injects `react-compiler-runtime`, this option is unnecessary. ghstack-source-id: 85e32a6468ef22a272256cacaa8b42e3f267a0ca Pull Request resolved: #31055
poteto
added a commit
that referenced
this pull request
Sep 26, 2024
Now that the compiler always injects `react-compiler-runtime`, this option is unnecessary. ghstack-source-id: c12286cd64ac217286497915fa2fb888a3957bf6 Pull Request resolved: #31055
poteto
added a commit
that referenced
this pull request
Sep 27, 2024
Now that the compiler always injects `react-compiler-runtime`, this option is unnecessary. ghstack-source-id: c2938c0851720ac24936de94f18dc77292a1f25e Pull Request resolved: #31055
poteto
added a commit
that referenced
this pull request
Sep 27, 2024
Now that the compiler always injects `react-compiler-runtime`, this option is unnecessary. ghstack-source-id: b8d31c13d50c9e03a9813ddd32f21ef1e548c1ad Pull Request resolved: #31055
poteto
added a commit
that referenced
this pull request
Sep 27, 2024
Now that the compiler always injects `react-compiler-runtime`, this option is unnecessary. ghstack-source-id: d0c9cc9233636360357388b46d225534df7926e3 Pull Request resolved: #31055
poteto
added a commit
that referenced
this pull request
Sep 27, 2024
Now that the compiler always injects `react-compiler-runtime`, this option is unnecessary. ghstack-source-id: 788fd4fbddf3ca0304f0f0b9ba9587d28273b3a7 Pull Request resolved: #31055
poteto
added a commit
that referenced
this pull request
Sep 27, 2024
Now that the compiler always injects `react-compiler-runtime`, this option is unnecessary. ghstack-source-id: 93379c69a9b1392a9124aa705b4d0fca1b3a6131 Pull Request resolved: #31055
|
Hmmm feels like we might want to keep this option for use internally where we're always on latest? |
poteto
added a commit
that referenced
this pull request
Oct 1, 2024
Now that the compiler always injects `react-compiler-runtime`, this option is unnecessary. ghstack-source-id: d8f7403ef9def00c92f4e2396be71ef953e31542 Pull Request resolved: #31055
|
@josephsavona hmm the new |
poteto
added a commit
that referenced
this pull request
Oct 1, 2024
Now that the compiler always injects `react-compiler-runtime`, this option is unnecessary. ghstack-source-id: 7ce2b9798a6ca427fd1151a69ef6ee8d18289bf7 Pull Request resolved: #31055
poteto
added a commit
that referenced
this pull request
Oct 1, 2024
Now that the compiler always injects `react-compiler-runtime`, this option is unnecessary. ghstack-source-id: 7ce2b9798a6ca427fd1151a69ef6ee8d18289bf7 Pull Request resolved: #31055
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Now that the compiler always injects
react-compiler-runtime, thisoption is unnecessary.