Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make enableOwnerStacks dynamic #31287

Closed
wants to merge 3 commits into from
Closed

Make enableOwnerStacks dynamic #31287

wants to merge 3 commits into from

Conversation

rickhanlonii
Copy link
Member

Ready to test this internally

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Oct 18, 2024
@vercel Vercel
Copy link

vercel bot commented Oct 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2024 6:06pm

@react-sizebot
Copy link

react-sizebot commented Oct 18, 2024 •
edited
Loading

Comparing: d572175...18ce70f

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 506.86 kB 506.86 kB = 90.71 kB 90.71 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 511.79 kB 511.79 kB = 91.43 kB 91.42 kB
facebook-www/ReactDOM-prod.classic.js = 604.26 kB 604.26 kB = 106.92 kB 106.92 kB
facebook-www/ReactDOM-prod.modern.js = 580.48 kB 580.48 kB = 103.00 kB 103.00 kB
facebook-react-native/react/cjs/JSXRuntime-dev.js +6.99% 24.99 kB 26.74 kB +4.44% 6.01 kB 6.27 kB
facebook-react-native/react/cjs/JSXDEVRuntime-dev.js +6.23% 24.93 kB 26.48 kB +4.28% 6.00 kB 6.26 kB
facebook-www/JSXDEVRuntime-dev.classic.js +4.54% 33.53 kB 35.05 kB +3.77% 7.75 kB 8.04 kB
facebook-www/JSXDEVRuntime-dev.modern.js +4.52% 33.40 kB 34.91 kB +3.70% 7.73 kB 8.01 kB
facebook-react-native/react/cjs/React-dev.js +4.37% 62.90 kB 65.64 kB +4.83% 13.78 kB 14.45 kB
facebook-www/React-dev.modern.js +3.65% 74.39 kB 77.10 kB +2.64% 16.24 kB 16.67 kB
facebook-www/React-dev.classic.js +3.61% 75.25 kB 77.97 kB +2.32% 16.41 kB 16.79 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
facebook-react-native/react/cjs/JSXRuntime-dev.js +6.99% 24.99 kB 26.74 kB +4.44% 6.01 kB 6.27 kB
facebook-react-native/react/cjs/JSXDEVRuntime-dev.js +6.23% 24.93 kB 26.48 kB +4.28% 6.00 kB 6.26 kB
facebook-www/JSXDEVRuntime-dev.classic.js +4.54% 33.53 kB 35.05 kB +3.77% 7.75 kB 8.04 kB
facebook-www/JSXDEVRuntime-dev.modern.js +4.52% 33.40 kB 34.91 kB +3.70% 7.73 kB 8.01 kB
facebook-react-native/react/cjs/React-dev.js +4.37% 62.90 kB 65.64 kB +4.83% 13.78 kB 14.45 kB
facebook-www/React-dev.modern.js +3.65% 74.39 kB 77.10 kB +2.64% 16.24 kB 16.67 kB
facebook-www/React-dev.classic.js +3.61% 75.25 kB 77.97 kB +2.32% 16.41 kB 16.79 kB
facebook-react-native/react/cjs/React-prod.js +1.75% 18.77 kB 19.10 kB +1.76% 4.87 kB 4.96 kB
facebook-react-native/react/cjs/React-profiling.js +1.71% 19.20 kB 19.53 kB +1.76% 4.95 kB 5.04 kB
facebook-www/ReactDOMServer-dev.modern.js +1.70% 356.21 kB 362.27 kB +1.38% 64.74 kB 65.64 kB
facebook-www/ReactDOMServerStreaming-dev.modern.js +1.69% 348.12 kB 354.01 kB +1.28% 63.51 kB 64.32 kB
facebook-www/ReactDOMServer-dev.classic.js +1.60% 363.34 kB 369.14 kB +1.24% 65.78 kB 66.60 kB
facebook-www/React-prod.modern.js +1.11% 27.25 kB 27.55 kB +0.99% 6.74 kB 6.80 kB
facebook-www/React-prod.classic.js +1.10% 27.38 kB 27.68 kB +0.95% 6.76 kB 6.83 kB
facebook-www/React-profiling.modern.js +1.09% 27.69 kB 27.99 kB +0.95% 6.82 kB 6.88 kB
facebook-www/React-profiling.classic.js +1.09% 27.81 kB 28.11 kB +0.98% 6.84 kB 6.91 kB
react-native/implementations/ReactFabric-dev.fb.js +0.84% 653.89 kB 659.36 kB +0.75% 107.21 kB 108.02 kB
react-native/implementations/ReactNativeRenderer-dev.fb.js +0.83% 660.87 kB 666.33 kB +0.77% 108.57 kB 109.41 kB
facebook-www/ReactART-dev.modern.js +0.74% 633.22 kB 637.90 kB +0.79% 101.42 kB 102.22 kB
facebook-www/ReactART-dev.classic.js +0.71% 655.74 kB 660.43 kB +0.72% 105.10 kB 105.85 kB
facebook-www/ReactReconciler-dev.modern.js +0.67% 718.51 kB 723.36 kB +0.70% 114.37 kB 115.17 kB
facebook-www/ReactReconciler-dev.classic.js +0.65% 742.44 kB 747.29 kB +0.63% 118.44 kB 119.19 kB
facebook-react-native/react-dom/cjs/ReactDOMClient-dev.js +0.60% 970.29 kB 976.07 kB +0.62% 164.05 kB 165.06 kB
facebook-react-native/react-dom/cjs/ReactDOMProfiling-dev.js +0.59% 986.64 kB 992.42 kB +0.61% 166.87 kB 167.89 kB
facebook-www/ReactDOM-dev.modern.js +0.55% 1,051.64 kB 1,057.42 kB +0.57% 176.48 kB 177.49 kB
facebook-www/ReactDOMTesting-dev.modern.js +0.54% 1,068.55 kB 1,074.33 kB +0.58% 180.36 kB 181.40 kB
facebook-www/ReactDOM-dev.classic.js +0.53% 1,087.57 kB 1,093.35 kB +0.58% 182.50 kB 183.57 kB
facebook-www/ReactDOMTesting-dev.classic.js +0.52% 1,104.48 kB 1,110.26 kB +0.56% 186.47 kB 187.51 kB

Generated by 🚫 dangerJS against 3bf371a

@noahlemen noahlemen mentioned this pull request Dec 3, 2024
Merged
noahlemen added a commit that referenced this pull request Dec 11, 2024
@noahlemen @rickhanlonii
Make enableOwnerStacks dynamic (#31661)
a496498 
following up on #31287, fixing
tests

---------

Co-authored-by: Rick Hanlon <rickhanlonii@fb.com>
@noahlemen noahlemen closed this Dec 11, 2024
@rickhanlonii rickhanlonii deleted the rh/dymanic-owner-stacks branch December 11, 2024 17:04
@rickhanlonii
Copy link
Member Author

Replaced by: #31661

github-actions bot pushed a commit that referenced this pull request Dec 11, 2024
@noahlemen
Make enableOwnerStacks dynamic (#31661)
0bcbbf0 
following up on #31287, fixing
tests

---------

Co-authored-by: Rick Hanlon <rickhanlonii@fb.com>

DiffTrain build for [a496498](a496498)
github-actions bot pushed a commit that referenced this pull request Dec 11, 2024
@noahlemen
Make enableOwnerStacks dynamic (#31661)
95e5f95 
following up on #31287, fixing
tests

---------

Co-authored-by: Rick Hanlon <rickhanlonii@fb.com>

DiffTrain build for [a496498](a496498)
github-actions bot pushed a commit to code/lib-react that referenced this pull request Dec 11, 2024
@pull
Make enableOwnerStacks dynamic (facebook#31661)
0e3974e 
following up on facebook#31287, fixing
tests

---------

Co-authored-by: Rick Hanlon <rickhanlonii@fb.com>

DiffTrain build for [a496498](facebook@a496498)
github-actions bot pushed a commit to code/lib-react that referenced this pull request Dec 11, 2024
@pull
Make enableOwnerStacks dynamic (facebook#31661)
ed791ae 
following up on facebook#31287, fixing
tests

---------

Co-authored-by: Rick Hanlon <rickhanlonii@fb.com>

DiffTrain build for [a496498](facebook@a496498)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebmarkbage sebmarkbage sebmarkbage approved these changes

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rickhanlonii @react-sizebot @sebmarkbage @noahlemen @facebook-github-bot