Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove terser from react-compiler-runtime build #31326

Merged

Conversation

henryqdineen
Copy link
Contributor

Summary

This fixes a minor nit I have about the react-compiler-runtime package in that the published code is minified. I assume most consumers will minify their own bundles so there's no real advantage to minifying it as part of the build.

For my purposes it makes it more difficult to read the code, use patch-package (if needed), or diff two versions without referencing the source code on github or mapping it back to original source using the source maps.

How did you test this change?

I ran the build locally and looked at the result but did not run the code. It's a lot more readable except for the commonjs compatibility-related stuff that Rollup inserts.

Copy link

vercel bot commented Oct 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 7:56pm

@poteto
Copy link
Member

poteto commented Oct 22, 2024

thanks!

@poteto poteto merged commit b4cbdc5 into facebook:main Oct 22, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants