Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flight] Allow <anonymous> stack frames to be serialized if opt-in #31329

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

sebmarkbage
Copy link
Collaborator

Normally we filter out stack frames with missing filename because they can be noisy and not ignore listed. However, it's up to the filterStackFrame function to determine whether to do it. This lets us match <anonymous> stack frames in V8 parsing (they don't have line numbers).

Copy link

vercel bot commented Oct 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2024 7:12am

@sebmarkbage sebmarkbage changed the title Allow <anonymous> stack frames to be serialized if opt-in [Flight] Allow <anonymous> stack frames to be serialized if opt-in Oct 23, 2024
@facebook-github-bot facebook-github-bot added the React Core Team Opened by a member of the React Core Team label Oct 23, 2024
@react-sizebot
Copy link

Comparing: b4cbdc5...a3fda99

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.82 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 506.86 kB 506.86 kB = 90.71 kB 90.71 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB +0.05% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 511.79 kB 511.79 kB = 91.42 kB 91.42 kB
facebook-www/ReactDOM-prod.classic.js = 604.26 kB 604.26 kB = 106.92 kB 106.92 kB
facebook-www/ReactDOM-prod.modern.js = 580.48 kB 580.48 kB = 103.00 kB 103.01 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 62f71f4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants