Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[react-compiler-runtime] Support React 17 peer dependency #31336

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

swissspidy
Copy link
Contributor

Summary

The recent blog post and documentation say that react-compiler-runtime supports React 17, yet it currently requires React 18 or 19 as a peer dependency, making it unusable for installing on a project still using React 17.

How did you test this change?

Manually installing the package on a React 17 codebase.

The recent blog post and [documentation](https://react.dev/learn/react-compiler#using-react-compiler-with-react-17-or-18) say that `react-compiler-runtime` supports React 17, yet it currently requires React 18 or 19 as a peer dependency, making it unusable for installing on a project still using React 17.
Copy link

vercel bot commented Oct 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 6:08pm

@facebook-github-bot
Copy link

Hi @swissspidy!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

Co-authored-by: lauren <poteto@users.noreply.github.com>
Copy link
Member

@poteto poteto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants