Failing tests of combining <Activity> and use() #31417
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deployment failed with the following error: View Documentation: https://vercel.com/docs/accounts/team-members-and-roles |
facebook-github-bot
added
CLA Signed
React Core Team
josephsavona
force-pushed
the
use-activity-bug
branch
from
6c69ded to
3c17f3f
Compare
Merged
I created a copy of ActivitySuspense-test that suspends via `use()`, which shows some errors that likely correspond to an infinite loop I'm seeing when trying to integrate `use()` in Relay.
josephsavona
force-pushed
the
use-activity-bug
branch
from
3c17f3f to
8c930ed
Compare
josephsavona
commented
Nov 5, 2024
Comment on lines
+174
to
+216
| // @gate enableActivity | ||
| test.only('suspend, resolve, hide (forces refresh), suspend, reveal', async () => { | ||
| global.IS_REACT_ACT_ENVIRONMENT = true; | ||
| const root = ReactNoop.createRoot(); | ||
|
|
||
| let setMode; | ||
| function Container({text}) { | ||
| const [mode, _setMode] = React.useState('visible'); | ||
| setMode = _setMode; | ||
| useEffect(() => { | ||
| return () => { | ||
| Scheduler.log(`Clear [${text}]`); | ||
| textCache.delete(text); | ||
| }; | ||
| }); | ||
| return ( | ||
| //$FlowFixMe | ||
| <Suspense fallback="Loading"> | ||
| <Activity mode={mode}> | ||
| <AsyncText text={text} /> | ||
| </Activity> | ||
| </Suspense> | ||
| ); | ||
| } | ||
|
|
||
| await React.act(() => { | ||
| root.render(<Container text="hello" />); | ||
| }); | ||
| assertLog(['Suspend! [hello]']); | ||
| expect(root).toMatchRenderedOutput('Loading'); | ||
|
|
||
| await React.act(() => { | ||
| resolveText('hello'); | ||
| }); | ||
| assertLog(['hello']); | ||
| expect(root).toMatchRenderedOutput('hello'); | ||
|
|
||
| await React.act(() => { | ||
| setMode('hidden'); | ||
| }); | ||
| assertLog(['Clear [hello]', 'Suspend! [hello]']); | ||
| expect(root).toMatchRenderedOutput(''); | ||
| }); |
There was a problem hiding this comment.
this was the case that failed w an infinite loop
|
Pushed tests to #31434 with you as co-author |
rickhanlonii
added a commit
that referenced
this pull request
Nov 11, 2024
## Overview In `scheduleTaskForRootDuringMicrotask` we clear `root.callbackNode` if the work loop is [suspended waiting on data](https://github.com/facebook/react/blob/ac3ca097aeecae8fe3ec7f9b286307a923676518/packages/react-reconciler/src/ReactFiberRootScheduler.js#L338). But we don't null check `root.callbackNode` before returning a continuation in `performWorkOnRootViaSchedulerTask` where `scheduleTaskForRootDuringMicrotask` is synchronously called, causing an infinite loop when the only thing in the queue is something suspended waiting on data. This essentially restores the behavior from here: https://github.com/facebook/react/pull/26328/files#diff-72ff2175ae3569037f0b16802a41b0cda2b2d66bb97f2bda78ed8445ed487b58L1168 Found by investigating the failures for #31417 ## TODO - add a test --------- Co-authored-by: Joe Savona <joesavona@fb.com>
github-actions bot
pushed a commit
that referenced
this pull request
Nov 11, 2024
## Overview In `scheduleTaskForRootDuringMicrotask` we clear `root.callbackNode` if the work loop is [suspended waiting on data](https://github.com/facebook/react/blob/ac3ca097aeecae8fe3ec7f9b286307a923676518/packages/react-reconciler/src/ReactFiberRootScheduler.js#L338). But we don't null check `root.callbackNode` before returning a continuation in `performWorkOnRootViaSchedulerTask` where `scheduleTaskForRootDuringMicrotask` is synchronously called, causing an infinite loop when the only thing in the queue is something suspended waiting on data. This essentially restores the behavior from here: https://github.com/facebook/react/pull/26328/files#diff-72ff2175ae3569037f0b16802a41b0cda2b2d66bb97f2bda78ed8445ed487b58L1168 Found by investigating the failures for #31417 ## TODO - add a test --------- Co-authored-by: Joe Savona <joesavona@fb.com> DiffTrain build for [b836de6](b836de6)
github-actions bot
pushed a commit
that referenced
this pull request
Nov 11, 2024
## Overview In `scheduleTaskForRootDuringMicrotask` we clear `root.callbackNode` if the work loop is [suspended waiting on data](https://github.com/facebook/react/blob/ac3ca097aeecae8fe3ec7f9b286307a923676518/packages/react-reconciler/src/ReactFiberRootScheduler.js#L338). But we don't null check `root.callbackNode` before returning a continuation in `performWorkOnRootViaSchedulerTask` where `scheduleTaskForRootDuringMicrotask` is synchronously called, causing an infinite loop when the only thing in the queue is something suspended waiting on data. This essentially restores the behavior from here: https://github.com/facebook/react/pull/26328/files#diff-72ff2175ae3569037f0b16802a41b0cda2b2d66bb97f2bda78ed8445ed487b58L1168 Found by investigating the failures for #31417 ## TODO - add a test --------- Co-authored-by: Joe Savona <joesavona@fb.com> DiffTrain build for [b836de6](b836de6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created a copy of ActivitySuspense-test that suspends via
use(), which shows some errors that likely correspond to an infinite loop I'm seeing when trying to integrateuse()in Relay.