Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[playground] Fix incorrect ci path and change reporter #31572

Merged
merged 1 commit into from
Nov 19, 2024
Merged

[playground] Fix incorrect ci path and change reporter #31572

merged 1 commit into from
Nov 19, 2024

Conversation

poteto
Copy link
Member

@poteto poteto commented Nov 18, 2024 •
edited
Loading

@vercel Vercel
Copy link

vercel bot commented Nov 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 18, 2024 10:40pm

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Nov 18, 2024
@react-sizebot
Copy link

react-sizebot commented Nov 18, 2024 •
edited
Loading

Comparing: 2a4f250...9e9d264

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.82 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 509.94 kB 509.94 kB = 91.24 kB 91.24 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB +0.05% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 514.88 kB 514.88 kB = 91.95 kB 91.95 kB
facebook-www/ReactDOM-prod.classic.js = 594.55 kB 594.55 kB = 104.90 kB 104.90 kB
facebook-www/ReactDOM-prod.modern.js = 584.81 kB 584.81 kB = 103.32 kB 103.32 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 0dac86f

@poteto poteto mentioned this pull request Nov 18, 2024
Merged
@poteto poteto merged commit ee10c74 into main Nov 19, 2024
196 of 198 checks passed
@poteto poteto deleted the pr31572 branch November 19, 2024 00:18
poteto added a commit that referenced this pull request Nov 19, 2024
@poteto
[playground] Fix broken tests (#31573)
c866d75 
Our e2e setup with monaco is kinda brittle since it relies on the dom.
It seems like longish text gets truncated so let's just simpify all
these test cases.

---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/31573).
* __->__ #31573
* #31572
@vercel-release-bot vercel-release-bot mentioned this pull request Nov 20, 2024
Closed
This was referenced Dec 4, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@poteto @react-sizebot @facebook-github-bot