Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[crud] Fix deps comparison bug #31599

Merged
merged 1 commit into from
Nov 20, 2024
Merged

[crud] Fix deps comparison bug #31599

merged 1 commit into from
Nov 20, 2024
+115 −42

Commits on Nov 20, 2024

  1. [crud] Fix deps comparison bug 

    Fixes a bug with the experimental `useResourceEffect` hook where we would compare the wrong deps when there happened to be another kind of effect preceding the ResourceEffect. To do this correctly we need to add a pointer to the ResourceEffect's identity on the update.

I also unified the previously separate push effect impls for resource effects since they are always pushed together as a unit.
    @poteto
    poteto committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    d6c45a7 View commit details
    Browse the repository at this point in the history