Allow <script> and <template> tags in <select> tag
#31837
Conversation
As per https://html.spec.whatwg.org/multipage/parsing.html#parsing-main-inselect, `<script>` and `<template>` tags may be nested in a `<select>` tag.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hi @jonathanhefner! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
Comparing: 74dd2da...0cc7ff8 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
Summary
As per https://html.spec.whatwg.org/multipage/parsing.html#parsing-main-inselect,
<script>and<template>tags may be nested in a<select>tag. This PR modifiesisTagValidWithParentto allow that.How did you test this change?
Based on #27632 (a similar PR), I did not add a test. I noticed that all the tests in
validateDOMNesting-test.jsare negative tests (i.e. expect warnings), not positive tests (i.e. expect no warnings), so I assume this is preferred. But I can add a test, if desired.