[assert helpers] forwardRef-test #31843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
CLA Signed
React Core Team
rickhanlonii
commented
Dec 18, 2024
| ' in ', | ||
| ); | ||
| (gate(flags => flags.enableOwnerStacks) | ||
| ? ' in **/forwardRef-test.js:**:** (at **)' |
There was a problem hiding this comment.
@sebmarkbage not sure if this is expected, but it's possible for owner stacks to have a file path in the name like here. I updated the normalizeCodeLocInfo to replace it if needed.
kassens
approved these changes
Dec 18, 2024
|
Comparing: ef979d4...d50e173 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
rickhanlonii
added a commit
that referenced
this pull request
Dec 19, 2024
github-actions bot
pushed a commit
to code/lib-react
that referenced
this pull request
Dec 19, 2024
Based off facebook#31843 Commit to review: facebook@2c653b8 Moar tests DiffTrain build for [36d15d5](facebook@36d15d5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting to convert the rest of tests to the
assertConsoleTypeDevhelpers.