Update stale event docs in tutorial #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The example uses onSubmit but the docs were still referring to onKeyUp.
| @@ -483,7 +483,7 @@ var CommentForm = React.createClass({ | |||
|
|
|||
| #### Events | |||
|
|
|||
| React attaches event handlers to components using a camelCase naming convention. We attach an onKeyUp handler to the text field, check if the user has entered text and pressed the enter key and then clear the form fields. | |||
| React attaches event handlers to components using a camelCase naming convention. We attach an onSubmit handler to the form that clear the form fields if the user has entered text in both. | |||
There was a problem hiding this comment.
Good catch! 2 things:
... onSubmit handler to the form that clear the form fields ...
"clears"
... if the user has entered text in both.
This doesn't flow as well as I'd like. How about something like "when the form is submitted with with valid input"?
|
Ah there's a bug in the tutorial; can you add a "return false" to handleSubmit and document that as well? Thanks. |
|
Done. |
petehunt
added a commit
that referenced
this pull request
May 31, 2013
Update stale event docs in tutorial
bvaughn
added a commit
to bvaughn/react
that referenced
this pull request
Aug 13, 2019
Experimenting with portals [WIP]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example uses onSubmit but the docs were still referring to onKeyUp.