Don't thread index through traverseAllChildren #3651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not super attached to this, but this feels cleaner to me. Might even be faster since flattenChildren doesn't use the index. Probably no change though.
|
Seems like this whole first class function paradigm is making this slower and more complicated than it needs to be if we were just willing to duplicate a little code. |
|
You mean write different variants of traverseAllChildren with the different callbacks inlined? |
sophiebits
added a commit
that referenced
this pull request
May 14, 2015
Don't thread index through traverseAllChildren
This was referenced Aug 18, 2021
This was referenced Sep 12, 2021
This was referenced May 13, 2022
This was referenced Nov 27, 2023
This was referenced Mar 22, 2024
This was referenced May 13, 2024
This was referenced May 14, 2024
This was referenced May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not super attached to this, but this feels cleaner to me. Might even be faster since flattenChildren doesn't use the index. Probably no change though.