Replace JSXTransformer with babel/browser #4131
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added import of babel browser plugin to transform JSX code - Removed occurrences of JSXTransformer from all places - Fixed jsx-compiler and live_editor to start using babel transform - Added rake task to start copying latest babel plugin for compilation
| render: function() { | ||
| return ( | ||
| <div> | ||
| <ReactPlayground | ||
| codeText={HELLO_COMPONENT} | ||
| renderCode={true} | ||
| transformer={transformer.bind(null, this.state.harmony)} | ||
| transformer={transformer.bind(null)} |
There was a problem hiding this comment.
Probably don't need to bind this (no this unsed in transformer)
- Get rid of transform function from jsx compiler and rely on babel instead
| render: function() { | ||
| return ( | ||
| <div> | ||
| <ReactPlayground | ||
| codeText={HELLO_COMPONENT} | ||
| renderCode={true} | ||
| transformer={transformer.bind(null, this.state.harmony)} |
There was a problem hiding this comment.
got rid of it altogether.
- Get rid of browser.min.js checked in _js - Start copying brower.min.js for babel to js/babel-browser.min.js - Get rid of JSXTransformer from js file
The babel browser file?
Renamed. |
|
Let me know, if there are any more changes expected here. |
|
Thanks! I think this should be good - going to try to land this and the other deprecation pieces close together in case we need to back out. |
zpao
pushed a commit
to zpao/react
that referenced
this pull request
Aug 20, 2015
This was referenced Aug 20, 2015
zpao
pushed a commit
to zpao/react
that referenced
this pull request
Sep 11, 2015
|
finally got this in. Thanks again! |
zpao
pushed a commit
that referenced
this pull request
Sep 26, 2015
This was referenced Jan 12, 2022
This was referenced Mar 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4129