-
Notifications
You must be signed in to change notification settings - Fork 47.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guard against a null node #4170
Conversation
It's not super obvious what should happen with events if a component switches away from null during the would-be transition time or if it switches to null while transitioning, but I guess this is an improvement either way. Can you squash your commits together? |
@spicyj embarrassing, but I don't know how to squash. Maybe you can provide me with a small exaple snippet so I know it once and for all? :) |
No worries. On your
meaning you want to edit the changes you've made since the top of the |
This could fix #2619
@spicyj I think that worked :) |
Thanks @johanneslumpe! |
This could fix #2619