Add <script> tags in the download page for easy embed #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vjeux
commented
Jun 3, 2013
vjeux
commented
zpao
added a commit
that referenced
this pull request
Jun 3, 2013
Add <script> tags in the download page for easy embed
taneliang
referenced
this pull request
in MLH-Fellowship/react
Aug 17, 2020
Summary --- Resolves #44. Intended to highlight all related React events. However, it looks like separate promises can have the same wakeable ID, which is a bit strange. TODO --- * Ensure that we are correctly understanding wakeable IDs, i.e. that a unique resource/promise is a unique wakeable. * Check if `unstable_createResource` caches promises. Test Plan --- * `yarn lint` * `yarn flow`: no errors in changed code
taneliang
referenced
this pull request
in MLH-Fellowship/react
Aug 19, 2020
Summary --- Resolves #44. Intended to highlight all related React events. However, it looks like separate promises can have the same wakeable ID, which is a bit strange. TODO --- * Ensure that we are correctly understanding wakeable IDs, i.e. that a unique resource/promise is a unique wakeable. * Check if `unstable_createResource` caches promises. Test Plan --- * `yarn lint` * `yarn flow`: no errors in changed code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.