Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setter for the ID_ATTRIBUTE_NAME to top-level React #4668

Closed

Conversation

dvdplm
Copy link

@dvdplm dvdplm commented Aug 20, 2015

To facilitate use-cases where multiple React apps are running on the same page,
expose the DOMPropery ID_ATTRIBUTE_NAME on the top-level React object and make
ReactMount reference the propery from DOMPropery rather than its own local copy.

This branch is based on 0.13-stable. Issue with background: #1939

To facilitate use-cases where multiple React apps are running on the same page,
expose the DOMPropery ID_ATTRIBUTE_NAME on the top-level React object and make
ReactMount reference the propery from DOMPropery rather than its own local copy
@zpao
Copy link
Member

zpao commented Aug 20, 2015

We definitely won't do this for 0.13 so I'm just going to close out so we can focus on the other PR.

@zpao zpao closed this Aug 20, 2015
@dvdplm
Copy link
Author

dvdplm commented Aug 21, 2015

@zpao that makes total sense (and I don't expect the other one to be merged as-is either, but one has to start somewhere right?). :)

@hakunin
Copy link

hakunin commented Mar 31, 2016

Whats the best way to set DOMProperty.ID_ATTRIBUTE_NAME these days? I tried setting it at the top if my code, but then get errors with bindings.

@hakunin
Copy link

hakunin commented Mar 31, 2016

Lot of people say they have to fork React just so they can modify ID_ATTRIBUTE_NAME.
While its great that v15 doesn't need this, it would be best if we could avoid the forks and just be able to set this variable in v14 now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants