Walk down internal tree to find DOM node #4988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sebmarkbage This one's for you too. Does adding |
sophiebits
force-pushed
the
fdn
branch
2 times, most recently
from
769d0ee
to
a39217a
Compare
|
^^ Updated to simplify code and remove empty component registry (now unnecessary!). |
|
Looks good to me, I'm assuming this is also destined for 0.15. |
|
Yes. |
sophiebits
force-pushed
the
fdn
branch
3 times, most recently
from
472739d
to
d7d9de1
Compare
|
@sebmarkbage You said you'd prefer to store the rendered node type (native, composite, or empty) on each composite rather than the actual element/node. Like this? |
| EMPTY: 2, | ||
|
|
||
| getType: function(node) { | ||
| if (node === null || node === false) { |
There was a problem hiding this comment.
Perhaps this logic should be shared for guaranteed consistency? (instantiateReactComponent has it too)
There was a problem hiding this comment.
Yeah maybe that should use this.
This reduces our reliance on hierarchical IDs.
sophiebits
added a commit
that referenced
this pull request
Oct 14, 2015
Walk down internal tree to find DOM node
|
@spicyj updated the pull request. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces our reliance on hierarchical IDs.