Stop generating gh-pages during release, update message #5147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var done = this.async(); | ||
|
|
||
| grunt.file.copy('build/react-' + VERSION + '.zip', 'docs/downloads/react-' + VERSION + '.zip'); | ||
| grunt.file.copy('build/react.js', 'docs/js/react.js'); |
There was a problem hiding this comment.
Isn't this part still important?
zpao
force-pushed
the
update-release-task
branch
from
3113b13
to
f7a3ac2
Compare
zpao
changed the title
|
@zpao updated the pull request. |
| @@ -134,8 +107,10 @@ function msg() { | |||
| var steps = [ | |||
| 'Still todo:', | |||
| '* put files on CDN', | |||
| '* add starter pack (git add -f docs/downloads/react-version.zip)', | |||
There was a problem hiding this comment.
You also need to commit, right?
There was a problem hiding this comment.
Yea but I figured the people doing this (me and you) are smart enough to know that. This isn't meant to be a complete step by step but a gentle reminder
zpao
added a commit
that referenced
this pull request
Oct 13, 2015
Stop generating gh-pages during release, update message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't push the gh-pages branch directly anymore so get rid of that code from our release process.