Add support for "invalid" event within Form elements #5187
Conversation
| @@ -687,6 +698,19 @@ ReactDOMComponent.Mixin = { | |||
| }, | |||
|
|
|||
| /** | |||
| * Setup this component to trap non-bubbling events locally | |||
There was a problem hiding this comment.
I'm not sure if this description suffices but I didn't know how else to describe what it does!
|
Feedback welcome on approach and on how to unit/integration test this |
|
I don't see anything wrong here; looks good to me. @tomduncalf Did you test it manually in a browser to verify it works? It is possible to write tests that fire mocked events, but honestly it's pretty fragile. |
|
Yes, tested manually - can share the test case if you like. Couldn't see anywhere obvious to hook into unit testing it!
|
|
Ok, looks good to me. Thanks @tomduncalf! |
…5152 Add support for "invalid" event within Form elements
| this._wrapperState = { | ||
| listeners: null, | ||
| }; | ||
| transaction.getReactMountReady().enqueue(trapBubbledEventsLocal, this); |
There was a problem hiding this comment.
The mountWrapper calls in input, select, and textarea should include the listeners property in their _wrapperState to avoid changing the hidden class when the assignment is made. This would also be better just as a free function – we're trying to get away from OO in the core anyway.
There was a problem hiding this comment.
@spicyj Makes sense - probably worth raising a separate issue for this as this PR is now merged
There was a problem hiding this comment.
I know it's merged. I was hoping that one of you would want to post a PR to fix it but I did it myself in #5213.
There was a problem hiding this comment.
Cool - thank you!
Fixes #5152