Fixes shallow rendering of component children (fixes #5292) #5299
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the issues with shallow rendering and
_owner
mentioned in #5292. Assertions around the equality of component children expect_owner
to benull
, but shallow rendering was setting a real_owner
.The test case I provided is based on the failure mentioned in #5292. Setting the component body directly still worked with the original
NoopInternalComponent
, and using simpler children didn't require the full fix - that's why the component is kind of unusual :)I've seen similar issues when composing (functional) components, but there's a secondary issue there around the component's
type
that I can submit a separate issue and PR for.