remove eslint-disable when possible and update babel-eslint version #5352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chicoxyzzy
force-pushed
the
eslint-upgrade
branch
2 times, most recently
from
33533a5
to
131ce6d
Compare
chicoxyzzy
force-pushed
the
eslint-upgrade
branch
from
131ce6d
to
b81328f
Compare
chicoxyzzy
changed the title
|
@chicoxyzzy updated the pull request. |
| /*eslint-disable camelcase */ | ||
| compare_size: require('./grunt/config/compare_size'), | ||
| /*eslint-enable camelcase */ | ||
| 'compare-size': require('./grunt/config/compare-size'), |
There was a problem hiding this comment.
I don't think you can do this since the actual task is compare_size and the way grunt works is that it matches the config name up with the task of the same name. Does the task still work for you?
|
Since you're dealing with lint stuff… want to update to eslint 1.8 as well and make sure we don't have other changes needed? Thanks! |
chicoxyzzy
force-pushed
the
eslint-upgrade
branch
from
b81328f
to
4a7456a
Compare
|
ok I'll do it |
|
@chicoxyzzy updated the pull request. |
facebook-github-bot
added
GH Review: review-needed
and removed
GH Review: needs-revision
labels
|
Lint passes for 1.8. I've updated eslint-plugin-react also |
|
@chicoxyzzy updated the pull request. |
|
Thanks! |
zpao
added a commit
that referenced
this pull request
Nov 5, 2015
remove eslint-disable when possible and update babel-eslint version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also compare_size was only file using snake_case so I renamed it