Warn on missing event handler properties #5361
Merged
+55
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ali
force-pushed
the
warn-on-missing-event-handlers
branch
from
9275f87 to
b2a8642
Compare
|
@ali updated the pull request. |
| @@ -265,6 +279,16 @@ var EventPluginRegistry = { | |||
| delete registrationNameModules[registrationName]; | |||
| } | |||
| } | |||
|
|
|||
| if (__DEV__) { | |||
| var getPossibleRegistrationName = EventPluginRegistry | |||
There was a problem hiding this comment.
style nit: Can you break after the equals sign instead of before the dot and indent only two spaces?
|
Looks good – thanks so much! Just a couple nits inline. If you could fix those and squash your commits, I think this is good to go. |
Fixes facebook#3548. Warns on properties that are case-insensitive matches for registered event names (e.g. "onclick" instead of "onClick").
ali
force-pushed
the
warn-on-missing-event-handlers
branch
from
b2a8642 to
9ad4be0
Compare
|
@ali updated the pull request. |
facebook-github-bot
added
GH Review: review-needed
and removed
GH Review: needs-revision
labels
|
Looks great, thank you so much! |
sophiebits
added a commit
that referenced
this pull request
Nov 3, 2015
Warn on missing event handler properties
|
Happy to, thanks for taking the time to review my change! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3548. Warns on properties that are case-insensitive matches for registered event names (e.g. "onclick" instead of "onClick").