ReactShallowRenderer.render returns the rendered output

[simonewebdesign]

I think would be nice to be able to chain functions this way:

let {props} = shallowRenderer.render(<MyComponent {...props} />).getRenderOutput();

This is not possible at the moment, as render() doesn't return itself, so I have to do it in two lines:

shallowRenderer.render(<MyComponent {...props} />);
let {props} = shallowRenderer.getRenderOutput();

[zpao]

I don't think we have any chaining APIs at the moment and I'm not sure it's worth the inconsistency to add one now. cc @spicyj @sebmarkbage who have more knowledge on the shallow renderer

[sebmarkbage]

Maybe render should just return the getRenderOutput?

cc @graue that might remember why we didn't.

[zpao]

cc @sebmarkbage who merged #4918 which added getRenderOutput (with relatedish discussion in #4056)

[sophiebits]

cc @zpao who commented twice on this issue

[zpao]

We have fun 😂 (sorry to distract from the main reason we're all here, which is to review this pull request)

[sebmarkbage]

cc @zpao who didn't realize that #4918 added getMountedInstance and not getRenderOutput which was added in #2497.

@simonewebdesign Would you prefer if it just returned getRenderOutput immediately since that seems more convenient for your use case and it's probably fairly common?

[facebook-github-bot]

@simonewebdesign updated the pull request.

[simonewebdesign]

@sebmarkbage I agree on that, the API would be more straightforward.

[hartzis]

Definitely like this change! @jsdf and @glenjamin either of you have concerns on this and how it could effect shallow rendering testing libraries?

[glenjamin]

Seems safe enough to me, as mentioned this should be the most common case.

[zpao]

Thanks!