Allow to render child custom component in shallow renderer #5513
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: https://medium.com/@bruderstein/the-missing-piece-to-the-react-testing-puzzle-c51cd30df7a0#.o7qri0ufc
Currently there is no way to easy refactor spaghetti components by smash them into smaller components while using shallow renderer to test. It fixes that.
I know, that inject custom
instantiateReactComponent
function is tricky, but I did not find better solution for this. I'm open for suggestions to do it better, maybe some core devs have some ideas?Im also not convinced about add components to the "whitelist" -
renderComponentsAsChild
array. This name does not explain purpose enough for me. Again, I'm open to any suggestions.The plus is, that there is no any regression in this but I'm little scary, that tests dont cover all corner cases so probably it should go as 0.15 release's feature, because users could report some bugs with them tests.