Improve PropTypes.oneOf warning for non-primitive values #5569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The improvement was suggested in facebook#1919.
|
Thanks for giving this a shot. I'm going to come back to this shortly. There are a couple other changes to PropType handling that I'd like to get in first. I also don't know that I agree with what you've done in practice (objects and functions are valid values in enums). |
| for (var i = 0; i < expectedValues.length; i++) { | ||
| if (expectedValues[i] !== null && | ||
| (typeof expectedValues[i] === 'object' || typeof expectedValues[i] === 'function') |
There was a problem hiding this comment.
Expected value can of type object/function, why restrict it?
|
@shuaibiyy updated the pull request. |
|
This hasn’t been updated in a while in response to a request for changes so I’m closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The improvement was suggested in #1919.