Remove DOM functions from top-level isomorphic API #5832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimfb
force-pushed
the
cleanup-top-level-dom-api
branch
from
001b565
to
2e1fb4b
Compare
|
Can you do a quick check to confirm nobody internally re-added calls before merging? |
|
@zpao Yeah. I have a few 0.15 diffs, so my plan was to just do a React sync once everything lands internally+github, and I'll verify for any stragglers as part of the sync (there should only be one or two at that point). |
jimfb
added a commit
that referenced
this pull request
Jan 13, 2016
Remove DOM functions from top-level isomorphic API
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove DOM functions from top-level isomorphic API. I have a couple diffs internally that make this safe. When they land, this should be good-to-go.