ReactChildren.map: only add slash if new child has key #5892
Conversation
|
cc @spicyj |
ianobermiller
force-pushed
the
children-map-key-slash
branch
from
4111232
to
39410e7
Compare
ianobermiller
changed the title
|
@ianobermiller updated the pull request. |
| @@ -117,7 +117,7 @@ function mapSingleChildIntoContext(bookKeeping, child, childKey) { | |||
| // traverseAllChildren used to do for objects as children | |||
| keyPrefix + | |||
| ( | |||
| mappedChild !== child ? | |||
| mappedChild !== child && mappedChild.key ? | |||
| escapeUserProvidedKey(mappedChild.key || '') + '/' : | |||
There was a problem hiding this comment.
Assume Ben likes this, can you drop the || '' here since we already know we have it.
There was a problem hiding this comment.
Haven't thought about this in super detail yet but why not mappedChild.key !== child.key as I suggested in chat?
There was a problem hiding this comment.
Yes, that makes sense, need to add a null-check then. Still need a truthy check on mappedChild.key, so mappedChild.key && (!child || mappedChild.key !== child.key)
|
Nice catch, thanks. |
ianobermiller
force-pushed
the
children-map-key-slash
branch
from
39410e7
to
86bfc80
Compare
|
@ianobermiller updated the pull request. |
See the new test for the scenario I am trying to fix; if you clone an element in React.cloneElement, vs just returning it directly, you will get a different key (with a slash in front) even though the two children are identical.
ianobermiller
force-pushed
the
children-map-key-slash
branch
from
86bfc80
to
30f7641
Compare
| @@ -117,8 +117,8 @@ function mapSingleChildIntoContext(bookKeeping, child, childKey) { | |||
| // traverseAllChildren used to do for objects as children | |||
| keyPrefix + | |||
| ( | |||
| mappedChild !== child ? | |||
| escapeUserProvidedKey(mappedChild.key || '') + '/' : | |||
| (mappedChild.key && (!child || (child.key !== mappedChild.key))) ? | |||
There was a problem hiding this comment.
I hate all the parens, but this makes it crystal clear.
|
@ianobermiller updated the pull request. |
|
Curious if/when this PR will be merged into master? This PR will fix a few problems we are dealing with in our project. Thanks! |
ReactChildren.map: only add slash if new child has key
|
I'm unfamiliar with the process... When can we expect it to be published on npm? |
|
After the next release major release, which is probably less than a month away :). |
See the new test for the scenario I am trying to fix; if you clone an
element in React.cloneElement, vs just returning it directly, you will
get a different key (with a slash in front) even though the two
children are identical.
Test Plan:
npm test -- src/isomorphic/children/__tests__/ReactChildren-test.js