Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NPE during reconciliation #6028

Merged
merged 3 commits into from
Feb 13, 2016
Merged

Fix NPE during reconciliation #6028

merged 3 commits into from
Feb 13, 2016

Commits on Feb 12, 2016

  1. Fix for issue/6027. 

    ReactDOMSelect's _handleChange function tries to set
this._wrapperState.pendingUpdate = true after executing the onChange
function. However, if the select was removed as a result of said
fuction, this._wrapperState would be null. Resulting in an
Uncaught TypeError: Cannot set property 'pendingUpdate' of null.
    Sam Beveridge committed Feb 12, 2016
    Configuration menu
    Copy the full SHA
    c4a2425 View commit details
    Browse the repository at this point in the history

  2. Forgot to 'not' the pendingUpdate condition.

    Sam Beveridge committed Feb 12, 2016
    Configuration menu
    Copy the full SHA
    385cadf View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2016

  1. Remove check for _wrapperState.pendingUpdate. 

    We can just set it to true regardless.
    Sam Beveridge committed Feb 13, 2016
    Configuration menu
    Copy the full SHA
    57d59ea View commit details
    Browse the repository at this point in the history