-
Notifications
You must be signed in to change notification settings - Fork 46.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn about deprecated SVG attributes only once #6184
Conversation
@@ -33,6 +33,7 @@ if (__DEV__) { | |||
warnedSVGAttributes.hasOwnProperty(name) && warnedSVGAttributes[name]) { | |||
return; | |||
} | |||
warnedSVGAttributes[name] = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a deal breaker, but seems a bit weird that warnedSVGAttributes
gets set to true even if a warning never fired (ie. bailed out in the next three lines). Maybe a few of these lines can be re-arranged to avoid this, maybe not worth the headache.
Two nits so small I wasn't even sure if I'd bother mentioning them, feel free to ignore if you want. |
This fixes a missing check in #5714
@gaearon updated the pull request. |
I made two changes:
|
👍 |
Warn about deprecated SVG attributes only once
This fixes a missing assignment in #5714 that caused tons of extraneous warnings.
Before
## After
Reviewers: @zpao