Remove react/addons #6285
Merged
Remove react/addons #6285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As long as this won't break the browser-with-addons builds, I'm good with this. 👍 @zpao manages the building/packaging, so it's worth pinging him for a go ahead. |
|
As far as I can see the UMD addons build uses |
|
I wish we had remembered to do this before rc but that's ok. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure what the plan is with 15.0 but accessing
react/addonsin the CommonJS environment has been deprecated since 0.14 betas. This commit removesreact/addonsentry point.If the consumer uses CommonJS, they need to switch to using
react-addons-<addon name>package as we warned during 0.14. If the consumer uses addons-enabled UMD build, they don’t need to change anything.Can we get this into v15?