Warning about unknown property happened when creating element #6345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -61,6 +59,4 @@ var ReactDOMDebugTool = { | |||
| }, | |||
| }; | |||
|
|
|||
| ReactDOMDebugTool.addDevtool(ReactDOMUnknownPropertyDevtool); | |||
There was a problem hiding this comment.
Why are you removing the devtool? This appears to be going in the wrong/opposite direction.
| null | ||
| ); | ||
|
|
||
| warning( |
There was a problem hiding this comment.
I think we want to use the “devtool” API for the new warnings. You can check how ReactDOMUnknownPropertyDevtool currently works for the context—it just needs to be called during the element creation.
…during property operation
|
I modified some method so that ReactDOMUnknownPropertyDevtool would be called on element creation. Is it the right way? |
|
@Sumei1009 updated the pull request. |
facebook-github-bot
added
GH Review: review-needed
and removed
GH Review: needs-revision
labels
This was referenced Apr 11, 2016
|
Can you please rebase so it merges cleanly, and fix the lint issues? You can run |
|
Ping @Sumei1009 |
Sumei1009
pushed a commit
to Sumei1009/react
that referenced
this pull request
Apr 14, 2016
Sumei1009
pushed a commit
to Sumei1009/react
that referenced
this pull request
Apr 14, 2016
Sumei1009
pushed a commit
to Sumei1009/react
that referenced
this pull request
Apr 14, 2016
Sumei1009
pushed a commit
to Sumei1009/react
that referenced
this pull request
Apr 14, 2016
Sumei1009
pushed a commit
to Sumei1009/react
that referenced
this pull request
Apr 14, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2887