Ensure validateDOMNesting catches nested body elements #6469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keyz
force-pushed
the
validate-foreignObject-children
branch
from
85b503e
to
fa748de
Compare
|
|
|
Yes, I think this seems reasonable. Thank you! Can you move |
|
Wait a second... I think this would break full-page rendering. While we generally recommend against FPR, it is a use case that people utilize. We should add a test that rendering |
|
@jimfb Line 187 should account for that. |
|
Also line 70 of the test. |
|
Oh, ok, I'm good with that. |
|
We do have a test. |
keyz
force-pushed
the
validate-foreignObject-children
branch
from
fa748de
to
6cf77ef
Compare
|
@keyanzhang updated the pull request. |
|
Thanks @keyanzhang! |
zpao
pushed a commit
that referenced
this pull request
Apr 28, 2016
Ensure validateDOMNesting catches nested body elements (cherry picked from commit 4016e71)
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes #6280.
Instead of adding a new list of rules to handle
foreignObject, I think the actual problem is that we don't have a clause that handles anotherbodyin "in body" parsing mode (e.g., pass this html snippet to the W3C validator to see the error message: "Start tagbodyseen but an element of the same type was already open").Thanks for reviewing! I could be totally wrong so any feedback is greatly appreciated.
cc @spicyj @toddgeist