Ignore DOM writes outside the batch in ReactPerf #6516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReactDOMInput and a few other classes handle change event by scheduling updateWrapper() in an asap(). It gets executed after the batch, which confuses ReactPerf that expects all DOM writes to happen during a batch. Since this implementation of ReactPerf relying on the stack is going away, let's plug the hole temporarily by ignoring DOM writes that occur during postponed updateWrapper(). In any case, they have no relation to actual calculations of wasted renders, as they don't occur due to updateComponent(), but rather due to onChange() special DOM behavior. This fixes #5548
|
Yeah, this seems okay. Thanks! |
zpao
pushed a commit
that referenced
this pull request
Apr 28, 2016
Ignore DOM writes outside the batch in ReactPerf (cherry picked from commit 6a93137)
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ReactDOMInputand a few other classes handle change event by schedulingupdateWrapper()in anasap(). It gets executed after the batch, which confusesReactPerfthat expects all DOM writes to happen during a batch.This causes it to throw when calculating
printWasted()if you interacted with an input before taking the measurement: #5548.Since this implementation of
ReactPerfrelying on the stack is going away, let's plug the hole temporarily by ignoring DOM writes that occur during postponedupdateWrapper(). In any case, they have no relation to actual calculations of wasted renders, as they don't occur due toupdateComponent(), but rather due toonChange()special DOM behavior.This fixes #5548. Thanks to @Danita for her help investigating the issue which allowed me to find the minimal case to repro this.