Don't warn about onScroll for SSR
#6678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aweary updated the pull request. |
| @@ -210,6 +211,7 @@ function assertValidProps(component, props) { | |||
| } | |||
|
|
|||
| function enqueuePutListener(inst, registrationName, listener, transaction) { | |||
| if (transaction instanceof ReactServerRenderingTransaction) return; | |||
There was a problem hiding this comment.
Can you make this this a block and across multiple lines? Lint is only warning about it so not failing Travis but you can see it locally.
|
@zpao I updated the PR with the linting fix and to use JSX in the test. |
ghost
added
|
@aweary updated the pull request. |
|
Thanks :) |
zpao
pushed a commit
that referenced
this pull request
May 10, 2016
(cherry picked from commit eb11648)
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6626
@zpao using
instanceofseems to work fine for identifyingReactServerRenderingTransactioninstances, so if that works for you this should resolve it.