Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] ReactTextComponent was renamed ReactDOMTextComponent a while ago #6700

Merged
merged 1 commit into from
May 4, 2016

Conversation

jayphelps
Copy link
Contributor

No description provided.

@jimfb
Copy link
Contributor

jimfb commented May 4, 2016

Eeh, ok. We generally don't take small changes like this, but this does fix a typo, so I suppose we can take it.

@jimfb jimfb merged commit fbe9002 into facebook:master May 4, 2016
@jayphelps
Copy link
Contributor Author

jayphelps commented May 4, 2016

@jimfb ah whoops, didn't realize. Sorry bout that. Is that to mitigate commit count inflating or something? I haven't seen this happen notably in any other major project, but I wouldn't doubt it does.

What's the sanctioned approach to fixing typos and other doc corrections?

@jimfb
Copy link
Contributor

jimfb commented May 4, 2016

@jayphelps There is some discussion in #6463

Generally, we prefer that you squish it into a more meaningful commit that happens to touch the same file. The TLDR is that these little micro-changes clutter the commit log for a given file and make it more difficult to track the more meaningful history/changes.

@zpao
Copy link
Member

zpao commented May 5, 2016

I think this one is probably fine but I would say we should do a sweep and ensure there are no other places that also need to be updated. This one is a bit different from #6463 since that was a code style change and this is more of a correctness thing.

@jayphelps
Copy link
Contributor Author

@zpao cool, thanks for clarifying. As far as sweep, this was indeed the only place where ReactTextComponent hadn't been updated.

@zpao zpao modified the milestones: 15.y.z, 15.0.3 May 16, 2016
zpao pushed a commit to zpao/react that referenced this pull request Jun 8, 2016
zpao pushed a commit that referenced this pull request Jun 14, 2016
@zpao zpao modified the milestones: 15-next, 15.2.0 Jun 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants