Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix severe perf problems in component tree devtool #6770

Merged
merged 1 commit into from
May 14, 2016
Merged

Fix severe perf problems in component tree devtool #6770

merged 1 commit into from
May 14, 2016

Commits on May 14, 2016

  1. Fix severe perf problems in component tree devtool 

    One of the ReactMultiChildText tests renders 2145 roots (and even more components) and unmounts none of them. Now we don't loop through them all a bunch of times so the test takes 20 seconds instead of 60.

We should clean up instantiateReactComponent somehow so that the onSetDisplayName call isn't produced for the TopLevelWrapper, which should allow us to just store an array of unmountedIDs instead of a hash map so we at least don't have double maps. This change mirrors the old logic though.

Reviewers: @gaearon, @sebmarkbage
    @sophiebits
    sophiebits committed May 14, 2016
    Configuration menu
    Copy the full SHA
    f657dbd View commit details
    Browse the repository at this point in the history