Extract the type checker into a separate module #6851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keyz
changed the title
| 'Failed %s type: %s%s', | ||
| location, | ||
| error.message, | ||
| elementOrInstance._debugID ? |
There was a problem hiding this comment.
Not sure if this is a good way to branch on the type of the argument
There was a problem hiding this comment.
You shouldn't need to branch. Just pass in the element as the argument. You can get the element off the instance by using instance._currentElement
There was a problem hiding this comment.
Cool, I'm fixing this now and it will take either an element or a debugID.
ghost
added
|
@keyanzhang updated the pull request. |
| * LICENSE file in the root directory of this source tree. An additional grant | ||
| * of patent rights can be found in the PATENTS file in the same directory. | ||
| * | ||
| * @providesModule checkTypes |
There was a problem hiding this comment.
Can we call this checkPropTypes or something else more descriptive? (I know you don't really like calling the context types prop types.) This name needs to be unique across the whole Facebook codebase.
|
@keyanzhang updated the pull request. |
zpao
pushed a commit
to zpao/react
that referenced
this pull request
Jun 8, 2016
The type checker is now a separate module under `isomorphic/classic/types` (cherry picked from commit db6ac5c)
zpao
pushed a commit
that referenced
this pull request
Jun 14, 2016
The type checker is now a separate module under `isomorphic/classic/types` (cherry picked from commit db6ac5c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #6824. The type checker is now a separate module under
isomorphic/classic/types, which takes either a React element or an internal component instance. As a result,ReactCompositeComponentnow displays the component stack info when type checking fails. Also, context type errors are memorized and will only be shown once.CC @spicyj