Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't count the time inside flushes towards lifecycle hooks #6860

Merged
merged 2 commits into from
May 25, 2016
Merged

Don't count the time inside flushes towards lifecycle hooks #6860

merged 2 commits into from
May 25, 2016

Commits on May 24, 2016

  1. Don't count the time inside flushes towards lifecycle hooks 

    Fixes #6842.

We keep the existing behavior of testing for matching `onBeginLifeCycleTimer`/`onEndLifeCycleTimer` calls, but we push the current timer onto the stack if we enter a flush.
This solves an issue with portals which cause updates while a lifecycle timer is already running.

I chose to subtract the time spent in the flush from the time counted towards the lifecycle method because it would artificially inflate the “total” time of the component due to all the components inside the portal, so it would skew the exclusive table.
    @gaearon
    gaearon committed May 24, 2016
    Configuration menu
    Copy the full SHA
    b3364fe View commit details
    Browse the repository at this point in the history

Commits on May 25, 2016

  1. Fix up the comment

    @gaearon
    gaearon committed May 25, 2016
    Configuration menu
    Copy the full SHA
    b21f64c View commit details
    Browse the repository at this point in the history