Followup to 6896, add explanation of workaround. #6905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -624,6 +624,8 @@ ReactDOMComponent.Mixin = { | |||
| } else if (props.is) { | |||
| el = ownerDocument.createElement(this._currentElement.type, props.is); | |||
| } else { | |||
| // Separate else branch instead of using `props.is || undefined` above becuase of a firefox bug. | |||
There was a problem hiding this comment.
Typo: becuase
Nit: let’s capitalize Firefox :-)
|
Let’s also add a link to https://bugzilla.mozilla.org/show_bug.cgi?id=1276240 |
jimfb
force-pushed
the
document-is-branching
branch
from
0ff54ae
to
6fbe512
Compare
|
@jimfb updated the pull request. |
zpao
pushed a commit
to zpao/react
that referenced
this pull request
Jun 8, 2016
(cherry picked from commit ba3bfe3)
zpao
pushed a commit
that referenced
this pull request
Jun 14, 2016
(cherry picked from commit ba3bfe3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #6896, add explanation of workaround.