-
Notifications
You must be signed in to change notification settings - Fork 46.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn that ReactPerf does not work in the production build #6975
Merged
gaearon
merged 12 commits into
facebook:master
from
gaearon:sashashakun-react-perf-warnings-changes
Jun 6, 2016
Merged
Warn that ReactPerf does not work in the production build #6975
gaearon
merged 12 commits into
facebook:master
from
gaearon:sashashakun-react-perf-warnings-changes
Jun 6, 2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gTool.GetFlushHistory
Ugh, I thought that would preserve @sashashakun as the commit author because all commits except the last one were his 😞 |
Reverted so that we preserve original contributor as author. |
@gaearon should i do one more commit? |
@sashashakun I merged it separately now, don’t worry 😄 . Thanks for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes #6884 and adds small stylistic changes on top.