Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn that ReactPerf does not work in the production build #6975

Merged
merged 12 commits into from
Jun 6, 2016
Merged

Warn that ReactPerf does not work in the production build #6975

merged 12 commits into from
Jun 6, 2016

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Jun 6, 2016

This takes #6884 and adds small stylistic changes on top.

@gaearon gaearon merged commit f71dfbc into facebook:master Jun 6, 2016
@gaearon
Copy link
Collaborator Author

gaearon commented Jun 6, 2016

Ugh, I thought that would preserve @sashashakun as the commit author because all commits except the last one were his 😞

gaearon added a commit that referenced this pull request Jun 6, 2016
, #6975)"

This reverts commit f71dfbc.

Reverting because GitHub stripped the original PR author.
@gaearon
Copy link
Collaborator Author

gaearon commented Jun 6, 2016

Reverted so that we preserve original contributor as author.

@sashashakun
Copy link
Contributor

@gaearon should i do one more commit?

@gaearon
Copy link
Collaborator Author

gaearon commented Jun 6, 2016

@sashashakun I merged it separately now, don’t worry 😄 . Thanks for contributing!

@gaearon gaearon deleted the sashashakun-react-perf-warnings-changes branch June 6, 2016 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants