group warnings for unknown DOM properties #7153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
| tagName, | ||
| ReactComponentTreeDevtool.getStackAddendumByID(debugID) | ||
| ); | ||
| unknownProp = name; |
There was a problem hiding this comment.
The calling function already knows the name of the unknown prop—it passes it as an argument. Let’s just return true if there is no need for additional warning, and false if we still need to warn. We can rename handleProperty to validateProperty.
|
Thanks! I left a few comments about refactoring but this mostly looks good! |
griffinmichl
force-pushed
the
unknownWarnings
branch
from
e1c2bfe
to
adf73d3
Compare
|
@gaearon Thanks for the feedback. I have incorporated your suggestions. |
| @@ -75,6 +75,8 @@ if (__DEV__) { | |||
| standardName, | |||
| ReactComponentTreeDevtool.getStackAddendumByID(debugID) | |||
| ); | |||
|
|
|||
There was a problem hiding this comment.
Nitpick: let’s remove this newline.
|
Accepting with nits. Please fix those and I’ll merge. Thanks! |
griffinmichl
force-pushed
the
unknownWarnings
branch
from
adf73d3
to
5ce2cbc
Compare
|
Nits fixed. |
|
Could you try this test:
A screenshot verifying it would be most welcome 😄 |
|
Sure thing!
|
zpao
pushed a commit
that referenced
this pull request
Jul 1, 2016
(cherry picked from commit 39265cb)
usmanajmal
pushed a commit
to usmanajmal/react
that referenced
this pull request
Jul 11, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7152. May need to refactor, but I think this is the idea.