Add failing test demonstrating a ReactPerf warning #7191
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #6949
When using ReactPerf from a component, I'm getting results back from
Perf.getWasted(measurements)
but I'm seeing this warning crop up too:cc @gaearon
I simplified the component that I shared in the issue for this failing test. The use case that led me to stumble into this is using a react component as a test fixture to benchmark re-render performance programatically.
The simplified test component cycles through a single state change and resolves in
componentDidUpdate
before checking the console error output. The warning is actually firing in thecomponentDidMount
hook as soon asReactPerf.start();
is called.(here's another jsfiddle with the simplified version: https://jsfiddle.net/69z2wepo/47901/)