Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass shouldHaveDebugID flag to instantiateComponent #7193

Merged
merged 3 commits into from
Jul 5, 2016
Merged

Pass shouldHaveDebugID flag to instantiateComponent #7193

merged 3 commits into from
Jul 5, 2016

Commits on Jul 5, 2016

  1. Add failing tests for #7187 and #7190

    @gaearon
    gaearon committed Jul 5, 2016
    Configuration menu
    Copy the full SHA
    9ea867f View commit details
    Browse the repository at this point in the history

  2. Pass shouldHaveDebugID flag to instantiateComponent 

    This allows us to remove a hack that was added in #6770 and caused #7187 and #7190.
    @gaearon
    gaearon committed Jul 5, 2016
    Configuration menu
    Copy the full SHA
    e24dae0 View commit details
    Browse the repository at this point in the history

  3. Move logic for choosing whether to use debugID outside instantiate

    @gaearon
    gaearon committed Jul 5, 2016
    Configuration menu
    Copy the full SHA
    b7e6505 View commit details
    Browse the repository at this point in the history