Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ReactPerf.start() work during reconciliation #7208

Merged
merged 7 commits into from
Jul 7, 2016
Merged

Make ReactPerf.start() work during reconciliation #7208

merged 7 commits into from
Jul 7, 2016

Commits on Jul 6, 2016

  1. Add failing test demonstrating a ReactPerf warning

    @nathanmarks @gaearon
    nathanmarks authored and gaearon committed Jul 6, 2016
    Configuration menu
    Copy the full SHA
    673d715 View commit details
    Browse the repository at this point in the history

  2. Make the failing ReactPerf test more precise

    @gaearon
    gaearon committed Jul 6, 2016
    Configuration menu
    Copy the full SHA
    c8b5018 View commit details
    Browse the repository at this point in the history

  3. Make ReactPerf.start() work during reconciliation

    @gaearon
    gaearon committed Jul 6, 2016
    Configuration menu
    Copy the full SHA
    4ea3f14 View commit details
    Browse the repository at this point in the history

  4. Reorder lifecycle methods for greater clarity

    @gaearon
    gaearon committed Jul 6, 2016
    Configuration menu
    Copy the full SHA
    13e9a29 View commit details
    Browse the repository at this point in the history

  5. Fix memory leak

    @gaearon
    gaearon committed Jul 6, 2016
    Configuration menu
    Copy the full SHA
    bcdfb21 View commit details
    Browse the repository at this point in the history

  6. Error boundaries should not break ReactPerf

    @gaearon
    gaearon committed Jul 6, 2016
    Configuration menu
    Copy the full SHA
    748e562 View commit details
    Browse the repository at this point in the history

  7. Put onBeginFlush/onEndFlush into transaction wrappers 

    This looks cleaner even though it is not strictly necessary.
We still call them manually for unmounting because it doesn't have a transaction.
    @gaearon
    gaearon committed Jul 6, 2016
    Configuration menu
    Copy the full SHA
    6850d20 View commit details
    Browse the repository at this point in the history