Avoid indexOf() during unmounting a root in the hook #7496
Conversation
ghost
added
| itemMap.delete(id); | ||
| return; | ||
| } else { |
There was a problem hiding this comment.
I replaced early returns with branches because it makes these two paths clearer in my opinion.
| if (canUseCollections) { | ||
| return Array.from(rootIDSet.keys()); | ||
| } else { | ||
| return Object.keys(rootByKey).map(getIDFromKey); |
There was a problem hiding this comment.
If we stored the id as the value then this could be Object.values(rootByKey). I suppose we don't know that's polyfilled though.
|
lgtm |
|
|
||
| function getRegisteredIDs() { | ||
| if (canUseCollections) { | ||
| return Array.from(itemMap.keys()); |
There was a problem hiding this comment.
.keys() is not yet supported in all implementations, IE supposedly does not support this. EDIT: Array.from is even less widely supported.
There was a problem hiding this comment.
I check for Array.from in canUseCollections.
Do you mean that a native Map may exist without Map.prototype.keys?
There was a problem hiding this comment.
Seems so (thanks for the tip!) I'll update to check for keys() specifically.
There was a problem hiding this comment.
My bad I missed it. It should sufficiently cover the case of .keys() I imagine 👍 EDIT: Yep, .keys() is not part of "basic support".
* Avoid indexOf() during unmounting a root in the hook * Check for (Map|Set).prototype.keys (cherry picked from commit 4847578)
Addresses @spicyj’s concerns in #7491 (comment).