Add playsInline as an allowed HTML property #7519
Conversation
The WHATWG has unprefixed `-webkit-playsinline` as `playsinline` (see: whatwg/html#1444) and iOS 10 intends to use it (https://webkit.org/blog/6784/new-video-policies-for-ios/).
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
ghost
added
the
|
bot appears to be a bit out of date, I signed the CLA about 15 minutes before submitting the PR 😄 |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
| optimum pattern placeholder playsInline poster preload profile radioGroup | ||
| readOnly rel required reversed role rowSpan rows sandbox scope scoped scrolling | ||
| seamless selected shape size sizes span spellCheck src srcDoc srcLang srcSet | ||
| start step style summary tabIndex target title type useMap value width wmode wrap |
There was a problem hiding this comment.
Can you actually revert the docs change? You have the right idea, we just try to do it in batches around releases (we can update all translations all at once more easily that way)
There was a problem hiding this comment.
No problem, I will revert it. I noticed that referrerPolicy appears to have been missed in this list (it was added in the 15.3 release) so you'll want to add that in addition to playsInline the next time you update these docs.
reaperhulk
force-pushed
the
reaperhulk-patch-1
branch
from
dff6031
to
4de1ea1
Compare
|
Do reviewers need anything from me? |
|
Nope, all looks good. Thanks for following up! |
zpao
added
Component: DOM
GH Review: accepted
and removed
GH Review: review-needed
labels
|
@zpao Thanks, this was a pleasant contributing experience! 👍 |
The WHATWG has unprefixed `-webkit-playsinline` as `playsinline` (see: whatwg/html#1444) and iOS 10 intends to use it (https://webkit.org/blog/6784/new-video-policies-for-ios/). (cherry picked from commit 7b11aa9)
|
I know that it isn't appropriate place to ask, but since it is related — I wonder, why in React has been opted to use this horrible idea of conversion of all HTML attributes to camel case? |
This patch allows
playsInlineas an attribute.The WHATWG has unprefixed
-webkit-playsinlineasplaysinline(see: whatwg/html#1444) and iOS 10 now uses it (https://webkit.org/blog/6784/new-video-policies-for-ios/).