-
Notifications
You must be signed in to change notification settings - Fork 47k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kill keyOf :) #7615
Kill keyOf :) #7615
Conversation
@@ -55,7 +54,7 @@ var mouseDown = false; | |||
// Track whether a listener exists for this plugin. If none exist, we do | |||
// not extract events. See #3639. | |||
var hasListener = false; | |||
var ON_SELECT_KEY = keyOf({onSelect: null}); | |||
var ON_SELECT_KEY = 'onSelect'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might inline this one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Accepted with nits. |
Inline the two, going to try your other suggestion in a separate PR |
I'm curious why |
Google Closure Compiler has an “advanced optimizations” mode that mangles |
(cherry picked from commit f7076b7)
It was removed in React: facebook/react#7615
See discussion here for the rationale: https://www.facebook.com/groups/2003630259862046/permalink/2097088000516271/
It doesn't have a big effect on file size: