Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy all SVG child nodes when using setting innerHTML in IE #7618

Merged
merged 1 commit into from
Aug 31, 2016

Conversation

zpao
Copy link
Member

@zpao zpao commented Aug 30, 2016

This is a followup to #6982, which missed half the nodes. We missed this because the test that was written depended on broken JSDOM behavior (will report shortly).

Test Plan:

I also renamed the test file to fit our convention.

@sophiebits
Copy link
Collaborator

I hope this isn't n^2 in some browsers.

@sophiebits
Copy link
Collaborator

Thanks.

@zpao zpao merged commit c73d863 into facebook:master Aug 31, 2016
@zpao zpao added this to the 15-next milestone Aug 31, 2016
@zpao zpao modified the milestones: 15.3.2, 15-next Sep 8, 2016
zpao added a commit that referenced this pull request Sep 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants