Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unknown property warning for use of autofocus #7694

Merged
merged 1 commit into from
Oct 3, 2016

Conversation

hkal
Copy link
Contributor

@hkal hkal commented Sep 10, 2016

Resolves #3248
Resubmission of #6461

cc @aweary @zpao

* @type {Object}
*/
getPossibleStandardName: __DEV__ ? {} : null,
getPossibleStandardName: __DEV__ ? {autofocus: 'autoFocus'} : null,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a space before the key name and after the value? { autofocus: 'autoFocus' }

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@aweary
Copy link
Contributor

aweary commented Sep 10, 2016

Accepted pending the small style change, I'll leave this open for @zpao just in case 😄

@aweary aweary added this to the 15-next milestone Sep 10, 2016
@ghost ghost added the CLA Signed label Sep 10, 2016
@ghost ghost added the CLA Signed label Sep 10, 2016
* @type {Object}
*/
getPossibleStandardName: __DEV__ ? {} : null,
getPossibleStandardName: __DEV__ ? { autofocus: 'autoFocus' } : null,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm so sorry @hkal, I guess we don't pad inline objects 😭 . You were totally right the first time.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries @aweary. I'll change it back.

@ghost ghost added CLA Signed labels Sep 10, 2016
@ghost ghost added the CLA Signed label Sep 11, 2016
@aweary aweary merged commit f6fdfd1 into facebook:master Oct 3, 2016
@zpao zpao modified the milestones: 15-next, 15.4.0 Oct 4, 2016
zpao pushed a commit that referenced this pull request Oct 4, 2016
acusti pushed a commit to brandcast/react that referenced this pull request Mar 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants